Added VassalGameFileName property #12763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om window title in Wizard.
riverwanderer
added
bug
This was
linked to
issues
Sep 29, 2023
|
This really needs to be a 3.8.0 enhancement. We can't have functionality that a module may use that is present in some versions of 3.7, but not others. |
Thanks for the feedback. Shall I split out the bug fix element from the new functionality or just leave it all until v3.8.0 ? |
|
Split out the additional functionality. Good to get any bug fixes in asap, even small. |
# Conflicts: # vassal-app/src/main/java/VASSAL/build/GameModule.java
uckelman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a property VassalGameFileName (akin to existing read-only properties such as ModuleVersion).
It is set to the file name of the most recent VSAV/VLOG.
Also fixes two issues with managing window title names from the Wizard which would have impeded the PR.