-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12260-Pre & Post Refresh Hotkeys #12694
12260-Pre & Post Refresh Hotkeys #12694
Conversation
I have tested this PR with the dev version of C&C Nap as follows:
Simple Refresh Counters and Refresh Predefined Setups trigger both 1 & 2. This PR adds another tool for the module maintainer. As per the linked request, it provides a hotkey hook that can be used to automatically convert multiple scenario files in ways that a refresh alone cannot do. The concept is that the mod dev will use this feature to perform such work "once off" and then disable or remove the maintenance functions. One caveat, if I understand Refresh correctly, any refresh done using "Refresh Predefined Setups" by design is done without triggering SGKCs. As long as the mod dev bears that in mind, VassalRefreshGHK could be useful to them too. I believe that the WiF developer may have been asking for this type of functionality recently, so I intend to offer him the build for testing & feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need some doco
vassal-app/src/main/java/VASSAL/build/module/GameRefresher.java
Outdated
Show resolved
Hide resolved
Ready to merge - re-tested with a pre as well as a post refresh GHK. Documentation is updated. Reserved Hotkeys are |
This reverts commit 0ee8714.
This reverts commit 0ee8714.
This reverts commit 7cd95ff.
This reverts commit 0ee8714.
Test hotkey VassalRefreshGHK.