Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12260 refresh pre & post #12757

Closed

Conversation

riverwanderer
Copy link
Collaborator

Re-submission of PR #12694.

Special hotkeys VassalGHKpreRefresh & VassalGHKpostRefresh provide maintenance hooks for module maintainers..

@riverwanderer riverwanderer added the enhancement New feature or request label Sep 28, 2023
@riverwanderer riverwanderer added this to the 3.7.2 milestone Sep 28, 2023
@riverwanderer riverwanderer self-assigned this Sep 28, 2023
@riverwanderer riverwanderer linked an issue Sep 28, 2023 that may be closed by this pull request
@riverwanderer riverwanderer added the Ready to Merge YeeeeeeeeeeeHAW!!! label Sep 28, 2023
@BrentEaston
Copy link
Collaborator

I think this one needs to be 3.8 as well. Again, it is new functionality that can be added to a module that will not work in all versions of 3.7,

@riverwanderer
Copy link
Collaborator Author

I think this one needs to be 3.8 as well. Again, it is new functionality that can be added to a module that will not work in all versions of 3.7,

This PR is not really applicable to game players, if that makes any difference. It's only useful as an adjunct to predefined refreshes and those are run by module developers, as part of the process of releasing an update to a module.

@uckelman uckelman modified the milestones: 3.7.2, 3.7.3 Oct 8, 2023
@Cattlesquat Cattlesquat added Review-Changes Complete Changes requested by reviewer have been completed and removed Ready to Merge YeeeeeeeeeeeHAW!!! labels Oct 15, 2023
@uckelman uckelman modified the milestones: 3.7.3, 3.8.0 Oct 16, 2023
@riverwanderer
Copy link
Collaborator Author

Superceded by #12890 which includes a control via the refresh control panel.

@riverwanderer riverwanderer deleted the 12260-refreshPost branch November 28, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Review-Changes Complete Changes requested by reviewer have been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh Predefined Setups - Programmable Post-Processing
4 participants