Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12688-Replace with other should not update text of unchangeable labels #12689

Merged
merged 2 commits into from
Sep 14, 2023
Merged

12688-Replace with other should not update text of unchangeable labels #12689

merged 2 commits into from
Sep 14, 2023

Conversation

BrentEaston
Copy link
Collaborator

@BrentEaston BrentEaston commented Sep 13, 2023 •
edited
Loading

If match current state is specified, then non-changeable Text Labels should be excluded from the state match process.

@BrentEaston BrentEaston added bug Something isn't working Awaiting Testing/Feedback Change is good, but neeeds testing or feedback labels Sep 13, 2023
@BrentEaston BrentEaston added this to the 3.7.1 milestone Sep 13, 2023
@BrentEaston BrentEaston linked an issue Sep 13, 2023 that may be closed by this pull request
Replace with Other not replacing Text Label #12688
Closed
@BrentEaston BrentEaston self-assigned this Sep 13, 2023
@BrentEaston BrentEaston added Ready for Review Ready to be reviewed for Merging Testing Complete Independent testing completed successfully and removed Awaiting Testing/Feedback Change is good, but neeeds testing or feedback labels Sep 14, 2023
@BrentEaston
Copy link
Collaborator Author

Original reporter confirms change resolves problem

@uckelman uckelman merged commit 3726fc4 into vassalengine:master Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BrentEaston BrentEaston

Labels
bug Something isn't working Ready for Review Ready to be reviewed for Merging Testing Complete Independent testing completed successfully
Projects
None yet
Milestone
3.7.1
Development

Successfully merging this pull request may close these issues.

Replace with Other not replacing Text Label
2 participants
@BrentEaston @uckelman