Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace with Other not replacing Text Label #12688

Closed
BrentEaston opened this issue Sep 12, 2023 · 1 comment · Fixed by #12689
Closed

Replace with Other not replacing Text Label #12688

BrentEaston opened this issue Sep 12, 2023 · 1 comment · Fixed by #12689
Assignees
Labels
bug Something isn't working Ready for Review Ready to be reviewed for Merging
Milestone

Comments

@BrentEaston
Copy link
Collaborator

The 'C' is in a Text Label trait in the 'Replace with other' definition in the 'GamePiece-Range C' prototype

Module is Fields of Fire. It does some (almost certainly overcomplicated!) stuff when a unit takes hits, and whilst I want to match some states, it is now inheriting ones that it didn;t before.

OK, so here's the problem....

Open module, start new game (pick any background)
Open Unit Pieces (F1), then click on 6th Bn Royal Australian Regiment, and drag 10 Pl Wpns 1 into play
Right click the unit and select Hit Results > Hit: A or F
This turns it into a Pinned Fireteam, which is correct, and will also keep the same ammo number in the blue box if you reduced that by using Ctrl-[ , which is also correct
What is incorrect, however is that the two letters bottom left and right on the counter should now read A and C, not A and L. The A and L has been inherited from the previous state.
If you look in editor, that counter is in Unit Pieces > Enemy and friendly counters > 6th Bn Royal Australian Regiment > 6th Bn Royal Australian Regiment > Core Units >D Company > D Company
If you look at the traits, the one being triggered with the hit result is the last one – Replace with other
This points at a counter in the Hidden Unit Pieces folder (same path as above after that).
In there, you will see that the counter is A C and not A L

I haven’t changed any trait orders before or after the 3.7.0 update, but it worked in 3.6.19

Not all the units have the same functionality with that 'replace with'. These Australian pieces are different to most other counters in the module, as they are built dynamically from layers, so the other units’ counters work ok….

@BrentEaston BrentEaston added the bug Something isn't working label Sep 12, 2023
@BrentEaston BrentEaston added this to the 3.7.1 milestone Sep 12, 2023
@BrentEaston BrentEaston self-assigned this Sep 12, 2023
@BrentEaston BrentEaston added Awaiting Testing/Feedback Change is good, but neeeds testing or feedback Ready for Review Ready to be reviewed for Merging Testing Complete Independent testing completed successfully and removed Awaiting Testing/Feedback Change is good, but neeeds testing or feedback labels Sep 13, 2023
@BrentEaston
Copy link
Collaborator Author

Original reporter of issue confirms fix resolves problem

@BrentEaston BrentEaston removed the Testing Complete Independent testing completed successfully label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for Review Ready to be reviewed for Merging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant