-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade React Native 0.66.4 #1697
Merged
Merged
Changes from 35 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
a02742c
update react native to 0.65.2, working for android debug
kathaypacific 3e1dccc
update react and react native types, remove AppState.removeEventListe…
kathaypacific 88a0196
update test config for RN upgrade
kathaypacific b108d70
update test snapshots
kathaypacific 1acf18b
upgrade to RN 0.66.4, working for android debug
kathaypacific afad186
fix failing tests
kathaypacific 611bdfd
update types
kathaypacific 50021ad
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 04e97d9
disable lintVitalApptestRelease for now, to test CI
kathaypacific 4f4da66
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 7cb09ca
update snapshots in react components package
kathaypacific 3bc990e
update yarn audit known issues to fix vulnerabilities pipeline
kathaypacific 9f6c78b
remove lintOptions to observe the android lint error in CI again
kathaypacific 1353d4b
test ios upgrade
kathaypacific 1b23e22
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 1282a66
update hermes for RN 0.66
kathaypacific 26f8594
Fix build issue related to "error: could not build module 'Foundation'"
jeanregisser 418200d
update how we set EXCLUDED_ARCHS in podfile for M1 machines
kathaypacific a45e3fc
fix user_project pod install error
kathaypacific c4e601e
update correct checksum in podfile
kathaypacific 94fbac3
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 655d050
update outdated snapshot
kathaypacific 557e8f9
attempt to fix persistent build error by clearing yarn cache
kathaypacific 1363db1
add step in android CI to clean build cache, to avoid app:mergeExtDex…
kathaypacific d3f3282
update react-native-geth dependency
kathaypacific 216f62e
remove gradle cache clean for android e2e
kathaypacific 15f2d8d
remove explicit dependency on viewpager that was causing intermittent…
kathaypacific cf4c0a2
put back plaid package in android manifest
kathaypacific c6d0a1a
update kotlin version to fix plaid build error
kathaypacific 50c0681
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 18e0835
update snapshots from main
kathaypacific b67c9c8
exclude material dependency from detox for android build to stop inte…
kathaypacific 5daa86a
remove plaid import in android manifest to avoid runtime error 'nativ…
kathaypacific 4fee9d9
put back viewpager in android dependency
kathaypacific d4f82bc
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific f512f33
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 2b4f016
Merge branch 'main' into kathy/upgrade-RN-65
MuckT 58e4873
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 5ee7ac1
update snapshots from main
kathaypacific 2deece0
Merge branch 'main' into kathy/upgrade-RN-65
mergify[bot] 029387a
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific 8192581
Merge branch 'main' into kathy/upgrade-RN-65
kathaypacific File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/mobile/android/gradle/wrapper/gradle-wrapper.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.2-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.9-all.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't have a better answer than i tried to copy the changes here https://react-native-community.github.io/upgrade-helper/?from=0.63.4&to=0.66.4 - my naive thinking is that newer versions of android has light/dark themes but i didn't look into it much. do you prefer to keep it unchanged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Maybe we should double check how the app is impacted when the dark theme is selected (Settings -> Display -> Theme).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quickly checked this, the app looks the same as usual in dark mode (except for the native things like keyboard and alerts which are dark) 🙈