Upgrade React Native 0.66.4 #1697

kathaypacific · 2021-12-29T13:09:55Z

Description

Upgrade react native to 0.66.4.

Notable changes in this PR include:

Android: upgrade to gradle version 4.2.2
Android: use mavenCentral as JCenter has been sunset - exoplayer is not available on mavenCentral yet so make an exception for that in build.gradle
Patch react-native-fast-crypto which is not compatible with gradle 4 yet
Update Hermes to compatible version
Update react native/react/react-test-renderer which required many test snapshots to be updated
Remove references to deprecated AppState.removeListener (https://reactnative.dev/docs/appstate#removeeventlistener)
Verified with activation team that Plaid button is still working correctly on Android. There was a runtime error on app launch which RN suggested to remove the Plaid package from Android Manifest, no official mention of this in the react-native-plaid-link-sdk project but following the RN suggestion worked (even though the react-native-plaid-link-sdk docs still mention these lines in the setup steps)

Other changes

N/A

Tested

E2E tests should work as usual, app should build and function as usual.

How others should test

A basic regression - click around the app and see no broken functionalities

Related issues

Fixes Upgrade React Native version #1145

Backwards compatibility

N/A

…ner which is now deprecated and causing tests to fail

codecov · 2021-12-29T15:19:11Z

Codecov Report

Merging #1697 (8192581) into main (2765358) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
- Coverage   76.58%   76.57%   -0.02%     
==========================================
  Files         520      520              
  Lines       19360    19359       -1     
  Branches     3544     3544              
==========================================
- Hits        14827    14824       -3     
- Misses       4464     4466       +2     
  Partials       69       69

Impacted Files	Coverage Δ
packages/mobile/src/app/saga.ts	`53.28% <0.00%> (+0.38%)`	⬆️
packages/mobile/src/navigator/DrawerTopBar.tsx	`90.90% <ø> (ø)`
...ckages/mobile/src/verify/VerificationCountdown.tsx	`85.71% <ø> (ø)`
packages/mobile/src/utils/useClipboard.ts	`91.30% <100.00%> (ø)`
...ages/react-components/components/SmartTopAlert.tsx	`60.00% <0.00%> (-5.46%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2765358...8192581. Read the comment docs.

…ApptestRelease error from gradle cache

… duplicate class build error

…rmittent duplicate class merge dex errors

…e module plaidandroid tried to override com.reactlibrary.plaidmodule' - need to check with activation squad if plaid still works

jeanregisser

OMG, amazing!! 🚀 🤩 🎉

jeanregisser · 2022-01-06T14:50:48Z

packages/mobile/android/app/src/main/res/values/styles.xml

@@ -2,7 +2,7 @@
  <style name="AppTheme" parent="Base.V0.AppTheme"/>

  <!--  Base theme, also see API specific overrides in values-vXX/styles.xml -->
-  <style name="Base.V0.AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
+  <style name="Base.V0.AppTheme" parent="Theme.AppCompat.DayNight.NoActionBar">


Why do we need to change this?

i don't have a better answer than i tried to copy the changes here https://react-native-community.github.io/upgrade-helper/?from=0.63.4&to=0.66.4 - my naive thinking is that newer versions of android has light/dark themes but i didn't look into it much. do you prefer to keep it unchanged?

Sounds good. Maybe we should double check how the app is impacted when the dark theme is selected (Settings -> Display -> Theme).

I quickly checked this, the app looks the same as usual in dark mode (except for the native things like keyboard and alerts which are dark) 🙈

packages/mobile/android/app/src/main/res/values/styles.xml

patches/react-native-fast-crypto+2.0.0.patch

jh2oman

Was able to build after switching my terminal to Rosetta mode.

### Description App was crashing on Android when proguard was enabled. This was caused by the `react-native-reanimated` upgrade in #1697 See software-mansion/react-native-reanimated#2725 ### Other changes - Detox release builds now use proguard too (with some Detox specific rules so it still works). This way, our e2e check has a higher chance of catching this type of issue. Though here, this specific reanimated proguard issue wouldn't have been caught. I tested it and apparently the Detox specific proguard rules made it disappear too. ### How others should test App starts on Android release builds without crashing. ### Related issues - Fixes #1789 ### Backwards compatibility Yes

kathaypacific added 8 commits December 28, 2021 11:31

update react native to 0.65.2, working for android debug

a02742c

update react and react native types, remove AppState.removeEventListe…

3e1dccc

…ner which is now deprecated and causing tests to fail

update test config for RN upgrade

88a0196

update test snapshots

b108d70

upgrade to RN 0.66.4, working for android debug

1acf18b

fix failing tests

afad186

update types

611bdfd

Merge branch 'main' into kathy/upgrade-RN-65

50021ad

kathaypacific and others added 19 commits December 30, 2021 09:20

disable lintVitalApptestRelease for now, to test CI

04e97d9

Merge branch 'main' into kathy/upgrade-RN-65

4f4da66

update snapshots in react components package

7cb09ca

update yarn audit known issues to fix vulnerabilities pipeline

3bc990e

remove lintOptions to observe the android lint error in CI again

9f6c78b

test ios upgrade

1353d4b

Merge branch 'main' into kathy/upgrade-RN-65

1b23e22

update hermes for RN 0.66

1282a66

Fix build issue related to "error: could not build module 'Foundation'"

26f8594

update how we set EXCLUDED_ARCHS in podfile for M1 machines

418200d

fix user_project pod install error

a45e3fc

update correct checksum in podfile

c4e601e

Merge branch 'main' into kathy/upgrade-RN-65

94fbac3

update outdated snapshot

655d050

attempt to fix persistent build error by clearing yarn cache

557e8f9

add step in android CI to clean build cache, to avoid app:mergeExtDex…

1363db1

…ApptestRelease error from gradle cache

update react-native-geth dependency

d3f3282

remove gradle cache clean for android e2e

216f62e

remove explicit dependency on viewpager that was causing intermittent…

15f2d8d

… duplicate class build error

jeanregisser mentioned this pull request Jan 5, 2022

Update dependency react-native to ^0.64.0 [SECURITY] #1715

Closed

1 task

MuckT mentioned this pull request Jan 5, 2022

Enable builds in Xcode 13.1 #1322

Closed

6 tasks

kathaypacific added 8 commits January 6, 2022 08:47

put back plaid package in android manifest

cf4c0a2

update kotlin version to fix plaid build error

c6d0a1a

Merge branch 'main' into kathy/upgrade-RN-65

50c0681

update snapshots from main

18e0835

exclude material dependency from detox for android build to stop inte…

b67c9c8

…rmittent duplicate class merge dex errors

remove plaid import in android manifest to avoid runtime error 'nativ…

5daa86a

…e module plaidandroid tried to override com.reactlibrary.plaidmodule' - need to check with activation squad if plaid still works

put back viewpager in android dependency

4fee9d9

Merge branch 'main' into kathy/upgrade-RN-65

d4f82bc

kathaypacific marked this pull request as ready for review January 6, 2022 10:19

jeanregisser reviewed Jan 6, 2022

View reviewed changes

jeanregisser approved these changes Jan 6, 2022

View reviewed changes

kathaypacific and others added 2 commits January 11, 2022 10:41

Merge branch 'main' into kathy/upgrade-RN-65

f512f33

Merge branch 'main' into kathy/upgrade-RN-65

2b4f016

jh2oman approved these changes Jan 11, 2022

View reviewed changes

kathaypacific added 2 commits January 12, 2022 09:08

Merge branch 'main' into kathy/upgrade-RN-65

58e4873

update snapshots from main

5ee7ac1

kathaypacific added the automerge Have PR merge automatically when checks pass label Jan 12, 2022

mergify bot and others added 3 commits January 12, 2022 08:44

Merge branch 'main' into kathy/upgrade-RN-65

2deece0

Merge branch 'main' into kathy/upgrade-RN-65

029387a

Merge branch 'main' into kathy/upgrade-RN-65

8192581

mergify bot merged commit 15c68ad into main Jan 12, 2022

mergify bot deleted the kathy/upgrade-RN-65 branch January 12, 2022 14:16

jeanregisser mentioned this pull request Jan 18, 2022

Fix crash on Android release builds #1798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade React Native 0.66.4 #1697

Upgrade React Native 0.66.4 #1697

kathaypacific commented Dec 29, 2021 •

edited

Loading

codecov bot commented Dec 29, 2021 •

edited

Loading

jeanregisser left a comment

jeanregisser Jan 6, 2022

kathaypacific Jan 6, 2022

jeanregisser Jan 6, 2022

kathaypacific Jan 12, 2022

jh2oman left a comment

Upgrade React Native 0.66.4 #1697

Upgrade React Native 0.66.4 #1697

Conversation

kathaypacific commented Dec 29, 2021 • edited Loading

Description

Other changes

Tested

How others should test

Related issues

Backwards compatibility

codecov bot commented Dec 29, 2021 • edited Loading

Codecov Report

jeanregisser left a comment

Choose a reason for hiding this comment

jeanregisser Jan 6, 2022

Choose a reason for hiding this comment

kathaypacific Jan 6, 2022

Choose a reason for hiding this comment

jeanregisser Jan 6, 2022

Choose a reason for hiding this comment

kathaypacific Jan 12, 2022

Choose a reason for hiding this comment

jh2oman left a comment

Choose a reason for hiding this comment

kathaypacific commented Dec 29, 2021 •

edited

Loading

codecov bot commented Dec 29, 2021 •

edited

Loading