Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates async test to skip if SSL not installed #36

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

kjaymiller
Copy link
Contributor

@kjaymiller kjaymiller commented Jul 5, 2024

Signed-off-by: Jay Miller [email protected]

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

PR that fixes commits from #34.

Creates parity in testing on the sync/async tests of the connection pool by skipping the ssl tests if ssl is not installed on the async tests.

Resolves #26

@kjaymiller
Copy link
Contributor Author

@aiven-sal this was the updated PR from #34 with the commit changes you suggested...

It was easier to create a new branch and cherry pick. I will do this with #33

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@5a7e4ca). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage        ?   75.02%           
=======================================
  Files           ?      132           
  Lines           ?    34352           
  Branches        ?        0           
=======================================
  Hits            ?    25774           
  Misses          ?     8578           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahmedsobeh
Copy link
Collaborator

LGTM! Thanks for submitting this one again too

@ahmedsobeh ahmedsobeh merged commit a5b54e0 into valkey-io:main Jul 7, 2024
46 checks passed
@kjaymiller kjaymiller deleted the jm-patches-34 branch August 8, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing pytest.mark.skipif on TestSSLConnectionURLParsing
4 participants