Skip to content

Commit

Permalink
updates async test to skip if SSL not installed (#36)
Browse files Browse the repository at this point in the history
Signed-off-by: Jay Miller <[email protected]>

### Pull Request check-list

_Please make sure to review and check all of these items:_

- [x] Do tests and lints pass with this change?
- [x] Do the CI tests pass with this change (enable it first in your
forked repo and wait for the github action build to finish)?
- [x] Is the new or changed code fully tested?
- [ ] Is a documentation update included (if this change modifies
existing APIs, or introduces new ones)?
- [ ] Is there an example added to the examples folder (if applicable)?
- [ ] Was the change added to CHANGES file?

_NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open._

### Description of change

PR that fixes commits from #34. 

Creates parity in testing on the sync/async tests of the connection pool
by skipping the ssl tests if ssl is not installed on the async tests.

Resolves #26

---------

Signed-off-by: Jay Miller <[email protected]>
Signed-off-by: Salvatore Mesoraca <[email protected]>
Co-authored-by: Salvatore Mesoraca <[email protected]>
  • Loading branch information
kjaymiller and aiven-sal authored Jul 7, 2024
1 parent 5a7e4ca commit a5b54e0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/test_asyncio/test_connection_pool.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from tests.conftest import skip_if_server_version_lt
from valkey._parsers.url_parser import to_bool
from valkey.asyncio.connection import Connection
from valkey.utils import SSL_AVAILABLE

from .compat import aclosing, mock
from .conftest import asynccontextmanager
Expand Down Expand Up @@ -542,6 +543,7 @@ def test_extra_querystring_options(self):
assert pool.connection_kwargs == {"path": "/socket", "a": "1", "b": "2"}


@pytest.mark.skipif(not SSL_AVAILABLE, reason="SSL not installed")
class TestSSLConnectionURLParsing:
def test_host(self):
pool = valkey.ConnectionPool.from_url("valkeys://my.host")
Expand Down

0 comments on commit a5b54e0

Please sign in to comment.