feat: frequency annotation helper #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
This was referenced Sep 29, 2024
Closed
Signed-off-by: Adnan Gulegulzar <[email protected]>
TylerGillson
reviewed
Oct 7, 2024
|
@ADorigi apologies for the delay - I was on PTO. Two small nits regarding logging, otherwise the changes look good! |
|
No worries @TylerGillson |
|
@ADorigi thanks for making those changes. We just need a |
dosubot
bot
added
size:XL
|
@TylerGillson |
Signed-off-by: Tyler Gillson <[email protected]>
dosubot
bot
added
size:M
|
@ADorigi you needed to do a |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #422 +/- ##
==========================================
+ Coverage 54.46% 55.01% +0.54%
==========================================
Files 23 24 +1
Lines 1153 1167 +14
==========================================
+ Hits 628 642 +14
Misses 457 457
Partials 68 68
Continue to review full report in Codecov by Sentry.
|
TylerGillson
added a commit
that referenced
this pull request
Nov 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.13](v0.1.12...v0.1.13) (2024-11-22) ### Features * frequency annotation helper ([#422](#422)) ([b2ca83f](b2ca83f)) ### Other * **deps:** bump github.com/golang-jwt/jwt/v4 from 4.5.0 to 4.5.1 ([#438](#438)) ([b69e66f](b69e66f)) * update renovate.json ([96c3ea7](96c3ea7)) * Update renovate.json ([#436](#436)) ([d720806](d720806)) ### Dependency Updates * **deps:** update actions/checkout digest to 11bd719 ([#430](#430)) ([dcc37af](dcc37af)) * **deps:** update actions/checkout digest to eef6144 ([#426](#426)) ([ae9976f](ae9976f)) * **deps:** update all non-major dependencies ([#437](#437)) ([8a2fb74](8a2fb74)) * **deps:** update golang.org/x/exp digest to 2d47ceb ([#439](#439)) ([4f2ffdf](4f2ffdf)) * **deps:** update golang.org/x/exp digest to f66d83c ([#425](#425)) ([edf709b](edf709b)) * **deps:** update kubernetes packages to v0.31.1 ([#388](#388)) ([5459610](5459610)) * **deps:** update kubernetes packages to v0.31.2 ([#431](#431)) ([16f3c2a](16f3c2a)) * **deps:** update module buf.build/gen/go/spectrocloud/spectro-cleanup/connectrpc/go to v1.17.0-20240205164452-95dfd137cb54.1 ([#421](#421)) ([274ba08](274ba08)) * **deps:** update module buf.build/gen/go/spectrocloud/spectro-cleanup/protocolbuffers/go to v1.35.1-20240205164452-95dfd137cb54.1 ([#428](#428)) ([728bbf1](728bbf1)) * **deps:** update module connectrpc.com/connect to v1.17.0 ([#420](#420)) ([1425343](1425343)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.21.0 ([#433](#433)) ([d2dbcf0](d2dbcf0)) * **deps:** update module github.com/onsi/gomega to v1.35.0 ([#434](#434)) ([274b277](274b277)) * **deps:** update module github.com/slack-go/slack to v0.15.0 ([#429](#429)) ([2ce3b4b](2ce3b4b)) * **deps:** update module github.com/validator-labs/validator-plugin-oci to v0.3.3 ([#396](#396)) ([011d5bd](011d5bd)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.3 ([#418](#418)) ([735df90](735df90)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.4 ([#427](#427)) ([67fbcfc](67fbcfc)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.19.0 ([#392](#392)) ([1c87bd3](1c87bd3)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.19.1 ([#432](#432)) ([7b2f95a](7b2f95a)) * **deps:** update softprops/action-gh-release digest to e7a8f85 ([#435](#435)) ([cb388ca](cb388ca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
partially resolves #358
Description
validation.validator.labs/reconciliation-frequency.FrequencyFromAnnotationswhich accepts annotation map and returnsctrl.Result.FrequencyFromAnnotationsfunction.