-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗 Reconciliation frequency configuration via annotations #358
Comments
Hi @TylerGillson, I would be willing to work on this issue. |
Hey @ADorigi. That would be fantastic! Contributions are very welcome. Let me know if you have any questions about how to get started. This epic requires a PR for all official plugins. |
Thank you @TylerGillson I will be starting with the After addition of the annotation, a simple resource definition of kind
I have taken the following points into consideration:
I will be working towards implementing the above. Please advise if the approach needs to be modified. |
Please use Your approach looks good! |
Hello @TylerGillson |
Hello @TylerGillson |
## Issue partially resolves #358 ## Description - A constant was added to define the annotation key `validation.validator.labs/reconciliation-frequency`. - Function `FrequencyFromAnnotations` which accepts annotation map and returns `ctrl.Result`. - Tests for `FrequencyFromAnnotations` function. --------- Signed-off-by: Adnan Gulegulzar <[email protected]> Signed-off-by: Tyler Gillson <[email protected]> Co-authored-by: Tyler Gillson <[email protected]>
## Issue Integrates annotation helper function from validator-labs/validator#358 ## Description - annotation for defining reconciliation frequency can now be specified. - providing the annotation is optional - example added to `config/samples/` ## Notes I tested the changes with a kind cluster. I had to remove `- "--metrics-bind-address=127.0.0.1:8080"` from the manager's arguments in `config/default/manager_auth_proxy_patch.yaml`. However, I reverted the change for this PR. --------- Signed-off-by: Adnan Gulegulzar <[email protected]>
Summary
Today, all validator plugin custom resources are re-reconciled every 2m. This value should be configurable.
The text was updated successfully, but these errors were encountered: