Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility for directives to have 'extra-options' defined in c… #84

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MaximilianSoerenPollak
Copy link
Contributor

This is the fourth 'split' PR that was discussed for splitting the big one into smaller ones. This one here #80

Note: PR depends on another. #83.

This PR adds the capability of the directives declared in the package to contain extra_options defined via the sphinx-needs option in conf.py.

Note: This PR has a similar issue as #83 issue being that the 8.1.3 Sphinx tests fail, with the same error message.

FAILED tests/test_custom_template.py::test_custom_koi8_template[test_app0] - sphinx.errors.ThemeError: An error happened in rendering the page index.
FAILED tests/test_custom_template.py::test_custom_utf8_template[test_app0] - sphinx.errors.ThemeError: An error happened in rendering the page index.
FAILED tests/test_custom_template.py::test_custom_template[test_app0] - sphinx.errors.ThemeError: An error happened in rendering the page index.

More exact:

E           sphinx.errors.ThemeError: An error happened in rendering the page index.
E           Reason: TemplateNotFound("'about.html' not found in ['/tmp/tmptxv71yyp/custom_tr_template/_templates', '/home/maxi/tmp/testing/sphinx-test-reports/.nox/tests-3-12-sphinx-8-1-3/lib/python3.12/site-packages/sphinx/themes/basic']")

.nox/tests-3-12-sphinx-8-1-3/lib/python3.12/site-packages/sphinx/builders/html/__init__.py:1201: ThemeError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant