-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling Sphinx-needs 4.1 compatibility & simplifying setup #80
base: master
Are you sure you want to change the base?
Enabling Sphinx-needs 4.1 compatibility & simplifying setup #80
Conversation
21a9a56
to
2babc7d
Compare
- Upgraded to allow for compaitiblity with Sphinx-needs 4.0+ - Changed paths to allow for better integration with other tools (like bazel). - Added setuptools as dependency as it wasn't there already but is used. - Added possibility for mutliple values in 'tr_link' targeted option - Enabled TestFileDirective, TestSuiteDirective, TestCaseDirective to have additional options from extra_links & extra_options - Edited tests to only test newer versions of Sphinx & Python - Fixed tests to account for new paths
2babc7d
to
bd3746a
Compare
Wow, this is quite a big PR and touches different fields. I guess Sphinx-Needs 4.0 support plus setuptools should be one PR. This makes all our lives much easier and reviews can be done much faster. But overall, I like all the changes and looking forward to finally merge them. If any help is needed, just let me know. |
Hi, yes I can split this into different parts, no problem. I'm unsure if there is a better way to do the directives / extra_options but i think that can be discussed in the accompanying PR. |
Currently working on splitting these up. |
Just pinging you as I have split up the PR into several smaller ones. I would then close this big PR if that's okay with you and we can discuss the details inside each PR. Just ping me inside the comments if I don't see/answer to a response from you. Looking forward to your thoughts and inputs. |
Argh sorry, for the late response. |
Let me know if I can help with anything. |
have additional options from extra_links & extra_options
Addresses: #78 #79
Please note:
Some of the tests do not pass the
about.html
is the problem, but all functionality seems to be right and present.I'm sure there is better ways to do some of the things that makes more sense, this should be seen as 'proof of concept' and starting point.
There also is an error I could not figure out:
Not quite sure where that comes from, or how do fix this one. It happens with all of the environment functions, not just this one