feat(uptest): make uptest usable for repo #14
Conversation
Signed-off-by: Christopher Haar <[email protected]>
haarchri
force-pushed
the
feature/e2e-uptest
branch
from
f6ebe5f to
2b57d0a
Compare
|
/test-examples="examples/genericsecret/genericsecret.yaml,examples/githubauthbackend/githubauthbackend.yaml,examples/githubteam/githubteam.yaml" |
|
/test-examples="examples/auth/authbackend.yaml" |
|
/test-examples="examples/kvsecret/kvsecret.yaml,examples/kvsecretv2/kvsecretv2.yaml,examples/token/token.yaml,examples/tokenauthbackendrole/tokenauthbackendrole.yaml" |
|
/test-examples="examples/mount/mount-generic-secrets.yaml,examples/mount/mount-kv-v1.yaml,examples/mount/mount-kv-v2.yaml" |
There was a problem hiding this comment.
It would be preferable if uptest can support Go 1.20 or better 1.21, and if we can move versions up versus backwards. golangci-lint would probably stay also at 1.53.3 with go1.20.5 if possible.
Ok to remove unused UPTEST_CLOUD_CREDENTIALS.
The UPTEST_EXAMPLE_LIST drives the e2e tests. Why should they be removed?
Is the hint that the local-dev cluster will remain after tests not useful?
Where should experimental tests reside? Are they not useful for users to experiment with as a foundation for their use cases?
examples/githubteam/githubteam.yaml line 25 "manageed" -> "managed"
|
@humoflife thanks for your comments
I didn't know that the PR-triggered comment workflow defaulted to Go version 1.19 for uptest. So, I've submitted a follow-up PR to switch it back to Go version 1.20 -> #16
We're examining PR comments to create the test example list. When working locally, you can set the ENV variable UPTEST_EXAMPLE_LIST, and we won't have a fixed UPTEST_EXAMPLE_LIST as it'll be rechecked across all the other official providers.
https://github.com/upbound/provider-aws/blob/main/Makefile#L190
In all other providers or configuration repositories, we don't include such a comment when using uptest. From my perspective, it's typical to use the upbound/build module for setting up local development clusters. In our CI process, we delete the cluster after the CI run.
I believe we have examples generated from the upjet, which people can review to explore experimental versions. |
Description of your changes
make uptest usable for repo
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested