fix: Rename Namespace MR to VaultNamespace #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaylevin
changed the title
Signed-off-by: Jordan Levin <[email protected]>
abhigarg28
reviewed
Apr 4, 2024
abhigarg28
reviewed
Apr 4, 2024
Signed-off-by: Jordan Levin <[email protected]>
…der-vault into jrl/fix-namespace
abhigarg28
approved these changes
Apr 4, 2024
jaylevin
commented
May 7, 2024
sergenyalcin
reviewed
May 8, 2024
Signed-off-by: Jordan Levin <[email protected]>
jaylevin
force-pushed
the
jrl/fix-namespace
branch
from
0a3caca to
4a792b7
Compare
jaylevin
commented
May 8, 2024
Signed-off-by: Jordan Levin <[email protected]>
jaylevin
changed the title
Thanks @sergenyalcin! It looks like I don't have write permission to merge this pull request. Is it possible for you to merge this the next time you can get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Namespaceresource toVaultNamespacein order to resolve naming conflict with the K8s nativeNamespaceresource.Fixes #12 (and the duplicate #31)
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested in a kubernetes cluster on Crossplane v1.15.1 and kubernetes v1.26