Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not include everything for rspack #354

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Nov 28, 2023

Now we're constrained to loading only those that come from unplugin

@antfu
Copy link
Member

antfu commented Nov 28, 2023

Do you know when rspack 0.4.0 will come out? And would the new changes still work in 0.3.0?

@bvanjoi
Copy link
Contributor Author

bvanjoi commented Nov 28, 2023

Do you know when rspack 0.4.0 will come out

It was released last week, and version 0.4.1 is set to be released this week.

And would the new changes still work in 0.3.0?

No, the changes necessitate a minimum version of 0.4.1.

@bvanjoi
Copy link
Contributor Author

bvanjoi commented Nov 28, 2023

It's peculiar that some CI checks have passed while others have failed. :|

package.json Outdated Show resolved Hide resolved
@bvanjoi bvanjoi force-pushed the not-load-everything-for-rspack branch from de77c9d to 9e9f172 Compare November 30, 2023 08:14
@bvanjoi bvanjoi force-pushed the not-load-everything-for-rspack branch from 9e9f172 to 2494af2 Compare November 30, 2023 08:22
@bvanjoi
Copy link
Contributor Author

bvanjoi commented Nov 30, 2023

The latest patch includes changes:

  • use @rspack/[email protected]
  • enable --no-threads for vitest because I suspect the previous panic was caused by multiple threads, so I have disabled them.

@Jungzl
Copy link

Jungzl commented Dec 4, 2023

👀

@ClarkXia
Copy link

Any progress?

@Jungzl
Copy link

Jungzl commented Dec 20, 2023

Any progress?

You can use this patch as a workaround.

@bvanjoi
Copy link
Contributor Author

bvanjoi commented Dec 25, 2023

friendly ping @antfu , can we proceed with this test?

@antfu antfu merged commit 8bb9bb9 into unjs:main Dec 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants