Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rspack plugin transform includes everything #350

Closed
wants to merge 1 commit into from
Closed

fix: rspack plugin transform includes everything #350

wants to merge 1 commit into from

Conversation

ruoruoji
Copy link

@ruoruoji ruoruoji commented Nov 14, 2023 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@ruoruoji
Copy link
Author

refer to this: #328

@antfu antfu requested a review from sxzz November 14, 2023 10:05
sxzz
sxzz previously approved these changes Nov 14, 2023
View reviewed changes
@antfu
Copy link
Member

antfu commented Nov 14, 2023

CI fails

@sxzz sxzz dismissed their stale review November 14, 2023 17:27

ci fails

@antfu
Copy link
Member

antfu commented Dec 26, 2023

Close in favor of #354, thanks

@antfu antfu closed this Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruoruoji @antfu @sxzz