CTP-3783 phpunit build fails

ucl-isd · Oct 28, 2024 · b8a9f84 · b8a9f84
1 parent 48bd4fe
commit b8a9f84
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib.php b/lib.php
@@ -938,7 +938,7 @@ function coursework_get_coursework_ids_from_context_id($contextid) {
             $coursemodule = get_coursemodule_from_id('coursework', $context->instanceid);
             $courseworkmoduleid = $DB->get_field('modules', 'id', ['name' => 'coursework']);
 
-            if ($coursemodule->module == $courseworkmoduleid) {
+            if ($coursemodule && $coursemodule->module == $courseworkmoduleid) {
                 $courseworkids[] = $coursemodule->instance;
             }
             break;

diff --git a/tests/generator_test.php b/tests/generator_test.php
@@ -46,6 +46,10 @@ final class generator_test extends \advanced_testcase {
      */
     public function setUp(): void {
         $this->resetAfterTest(true);
+        // If we don't do this, we end up with the same cached objects for all tests and they may have incorrect/missing properties.
+        \mod_coursework\models\coursework::$pool = null;
+        \mod_coursework\models\course_module::$pool = null;
+        \mod_coursework\models\module::$pool = null;
     }
 
     /**