Fix bug when no submissions notifiers are selected (#33)

ucl-isd · Oct 28, 2024 · 48bd4fe · 48bd4fe
1 parent f67154c
commit 48bd4fe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/classes/controllers/submissions_controller.php b/classes/controllers/submissions_controller.php
@@ -170,9 +170,10 @@ protected function create_submission() {
         if ($submission->finalised) {
             if (!$submission->get_coursework()->has_deadline()) {
 
-                $userids = explode(',', $submission->get_coursework()->get_submission_notification_users());
+                $useridcommaseparatedlist = $submission->get_coursework()->get_submission_notification_users();
 
-                if (!empty($userids)) {
+                if (!empty($useridcommaseparatedlist)) {
+                    $userids = explode(',', $useridcommaseparatedlist);
                     foreach ($userids as $u) {
                         $notifyuser = $DB->get_record('user', ['id' => trim($u)]);
 

diff --git a/classes/forms/student_submission_form.php b/classes/forms/student_submission_form.php
@@ -175,9 +175,10 @@ public function handle() {
 
                     if (!$submission->get_coursework()->has_deadline()) {
 
-                        $userids = explode(',', $submission->get_coursework()->get_submission_notification_users());
+                        $useridcommaseparatedlist = $submission->get_coursework()->get_submission_notification_users();
 
-                        if (!empty($userids)) {
+                        if (!empty($useridcommaseparatedlist)) {
+                            $userids = explode(',', $useridcommaseparatedlist);
                             foreach ($userids as $u) {
                                 $notifyuser = $DB->get_record('user', ['id' => trim($u)]);
                                 $mailer = new mailer($coursework);