Fix safe area observing for example query #124 #126
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ struct HostViewSectionFocusView: View { | |
| ScrollView { | ||
| HostViewSectionContent(sectionModel: model, canQuery: true) | ||
| } | ||
| HostBarView(url: url, date: date).background(Color(UIColor.systemGroupedBackground)) | ||
|
There was a problem hiding this comment. Why is this change necessary? There was a problem hiding this comment. HostBarView(url: url, date: date).background(Color(UIColor.systemGroupedBackground)) https://we.tl/t-FPltFCM832 Without background color , it will show like the given screenshot, there will be no background color. There was a problem hiding this comment. Shouldn't this just ignore the safe area? There was a problem hiding this comment. https://we.tl/t-2KPswENwxO attached screenshots , in case we use only the ignore safe area , or even without that there is no background color, but if we want background color , then we need to give background color |
||
| } | ||
| .navigationTitle(model.service.name) | ||
| .navigationBarTitleDisplayMode(.inline) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just have the relevant changes in the PR