Fix safe area observing for example query #124

[iphone201988]

No description provided.

[twodayslate]

Let's just have the relevant changes in the PR

[twodayslate]

Please rebase

[iphone201988]

https://we.tl/t-OjRjdFyePK already up to date

[twodayslate]

Why is this change necessary?

[iphone201988]

HostBarView(url: url, date: date).background(Color(UIColor.systemGroupedBackground))

https://we.tl/t-FPltFCM832 Without background color , it will show like the given screenshot, there will be no background color.

[twodayslate]

Shouldn't this just ignore the safe area?

[iphone201988]

https://we.tl/t-2KPswENwxO attached screenshots , in case we use only the ignore safe area , or even without that there is no background color, but if we want background color , then we need to give background color

[twodayslate]

Does https://twitter.com/natpanferova/status/1590676836488732678?s=46&t=DunNho2WvomMLprYw9b4pw help?

[iphone201988]

Does https://twitter.com/natpanferova/status/1590676836488732678?s=46&t=DunNho2WvomMLprYw9b4pw help?

If you check this link ,

Background color also given same as I implemented in snippet.

Please check these screenshots: https://we.tl/t-ujdUL7nHMj
I have added the code as suggested, but we need to provide the background color.

If background color is not provided it will show as: https://we.tl/t-SS3ovvpGF7

[twodayslate]

This seemed to work for me

diff --git a/ec3730/Views/Host/HostBarView.swift b/ec3730/Views/Host/HostBarView.swift
index 294cbc7..33358a6 100644
--- a/ec3730/Views/Host/HostBarView.swift
+++ b/ec3730/Views/Host/HostBarView.swift
@@ -41,11 +41,6 @@ struct HostBarView: View {
                 Spacer()
             }
         }
-        .background(
-            VisualEffectView(effect: UIBlurEffect(style: .systemMaterial))
-                .ignoresSafeArea(.all, edges: .horizontal)
-        )
-        .ignoresSafeArea()
         .confirmationDialog("Information", isPresented: $showInfo) {
             Button(action: {
                 UIPasteboard.general.string = url.absoluteString
@@ -58,6 +53,10 @@ struct HostBarView: View {
                 Label("Copy Date", systemImage: "doc.on.doc")
             })
         }
+        .background(
+            VisualEffectView(effect: UIBlurEffect(style: .systemMaterial))
+                .ignoresSafeArea()
+        )
     }
 }
 
diff --git a/ec3730/Views/Host/HostViewSectionFocusView.swift b/ec3730/Views/Host/HostViewSectionFocusView.swift
index 5f2f32d..0062999 100644
--- a/ec3730/Views/Host/HostViewSectionFocusView.swift
+++ b/ec3730/Views/Host/HostViewSectionFocusView.swift
@@ -10,10 +10,18 @@ struct HostViewSectionFocusView: View {
                 ScrollView {
                     HostViewSectionContent(sectionModel: model, canQuery: true)
                 }
-                HostBarView(url: url, date: date)
+                .safeAreaInset(edge: .bottom, spacing: 0) {
+                    HostBarView(url: url, date: date)
+                }
             }
             .navigationTitle(model.service.name)
             .navigationBarTitleDisplayMode(.inline)
         }
     }
 }
+
+struct HostViewSectionFocusViewPreview: PreviewProvider {
+    static var previews: some View {
+        HostViewSectionFocusView(model: WhoisXmlDnsSectionModel(), url: URL(string: "https://google.com")!, date: .now)
+    }
+}

[twodayslate]

It's also used in HostResult.swift

[iphone201988]

Please Suggest , on which ticket we can work upon next

1.#108
Add status progress bar for source view · Issue #108 · twodayslate/NetUtilsgithub.com
2.#101
Create Image enum/extension · Issue #101 · twodayslate/NetUtilsgithub.com
3.#102
Create UserDefaults extensions · Issue #102 · twodayslate/NetUtilsgithub.com
4.#98
Disable navigation to PingSetList if there are no ping sets · Issue #98 · twodayslate/NetUtilsgithub.com
5.#82
Hide host lookup bar on scroll · Issue #82 · twodayslate/NetUtilsgithub.com
6.#111

[iphone201988]

It's also used in HostResult.swift

https://we.tl/t-QxHhGQZNh6 This view has tabbar below , please check screenshot, If any updation required let me know.

[twodayslate]

Can that use the safe area unset as well?