Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Navigation scroll when overflow #7735

Closed
wants to merge 2 commits into from
Closed

[FIX] Navigation scroll when overflow #7735

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6c3f69
[FIX] Navigation scroll when overflow
Hitarthsheth07 Oct 16, 2024
e5c7a5b
Merge branch 'twentyhq:main' into main
Hitarthsheth07 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .../twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,12 @@ export type NavigationDrawerProps = {
title?: string;
};

const StyledAnimatedContainer = styled(motion.div)``;
const StyledAnimatedContainer = styled(motion.div)`
max-height: 100vh;
overflow: scroll;
Comment on lines +26 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider using overflow-y: auto instead of overflow: scroll to avoid unnecessary scrollbars when content doesn't overflow

display: flex;
justify-content: end;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: justify-content: end might affect the layout unexpectedly. Verify if this is necessary for the desired layout

`;

const StyledContainer = styled.div<{
isSettings?: boolean;
Expand Down
Loading