Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Navigation scroll when overflow #7735

Closed
wants to merge 2 commits into from

Conversation

Hitarthsheth07
Copy link
Contributor

FIX #7733

Changed the max height to 100vh and overflow to scroll when the contents are overflowing.

`display: flex;
justify-content: end; might not be needed but it is kept since it was there in the past version...

Copy link

github-actions bot commented Oct 16, 2024

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against e5c7a5b

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses the navigation bar overflow issue by modifying the NavigationDrawer component to enable scrolling when content exceeds the screen height.

  • Added max-height: 100vh and overflow: scroll to StyledAnimatedContainer in packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawer.tsx
  • Retained display: flex and justify-content: end properties, which may need further review for necessity
  • Potential consideration: Using overflow-y: auto instead of overflow: scroll to avoid unnecessary scrollbars
  • Possible improvement: Adding padding-bottom to ensure last items are fully visible when scrolling

1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +26 to +27
max-height: 100vh;
overflow: scroll;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider using overflow-y: auto instead of overflow: scroll to avoid unnecessary scrollbars when content doesn't overflow

max-height: 100vh;
overflow: scroll;
display: flex;
justify-content: end;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: justify-content: end might affect the layout unexpectedly. Verify if this is necessary for the desired layout

@Bonapara
Copy link
Member

Hi @Hitarthsheth07, thanks for raising this bug and PR! The scroll should only apply to the middle section of the navbar, which contains the navigable items. The workspace title and support button (only on the cloud version) should remain in the same position.

@Hitarthsheth07 Hitarthsheth07 closed this by deleting the head repository Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Bar extends beyond the screen size
2 participants