-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Navigation scroll when overflow #7735
Conversation
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses the navigation bar overflow issue by modifying the NavigationDrawer component to enable scrolling when content exceeds the screen height.
- Added
max-height: 100vh
andoverflow: scroll
toStyledAnimatedContainer
inpackages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawer.tsx
- Retained
display: flex
andjustify-content: end
properties, which may need further review for necessity - Potential consideration: Using
overflow-y: auto
instead ofoverflow: scroll
to avoid unnecessary scrollbars - Possible improvement: Adding padding-bottom to ensure last items are fully visible when scrolling
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
max-height: 100vh; | ||
overflow: scroll; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider using overflow-y: auto
instead of overflow: scroll
to avoid unnecessary scrollbars when content doesn't overflow
max-height: 100vh; | ||
overflow: scroll; | ||
display: flex; | ||
justify-content: end; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: justify-content: end
might affect the layout unexpectedly. Verify if this is necessary for the desired layout
Hi @Hitarthsheth07, thanks for raising this bug and PR! The scroll should only apply to the |
FIX #7733
Changed the max height to 100vh and overflow to scroll when the contents are overflowing.
`display: flex;
justify-content: end; might not be needed but it is kept since it was there in the past version...