Fix issues linked to name maximum length #6839
Conversation
| @@ -1 +1 @@ | |||
| export const DATABASE_IDENTIFIER_MAXIMUM_LENGTH = 63; | |||
| export const DATABASE_IDENTIFIER_MAXIMUM_LENGTH = 62; | |||
There was a problem hiding this comment.
What changed? It seems like we need to have objects no longer than 61 (62 - 1) characters long, I can't figure out why.
Getting errors like
QueryFailedError: type "_aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaao" already exists
There was a problem hiding this comment.
63 is the default limit for PSQL identifiers such as columns, tables, indexes etc
I'm guessing we need to remove 1 because we need to take into account the "_" for custom entities (as of today, only table names I believe). That logic should already exist though 🤔 @ijreilly
|
@ijreilly Can we close this PR? |
|
@bosiraphael I would like to resume working on it at some point but i can close it in the meantime if that helps with our "stats" of open PRs. or it would be good to take out draft PRs of the number of open PRs |
No description provided.