ci: fix duplicated rust suites test #1078
Conversation
| run: | | ||
| cd ext/crr/rs/core | ||
| cargo test --features=loadable_extension | ||
|
|
There was a problem hiding this comment.
hey, this should not be removed
There was a problem hiding this comment.
I reverted this! Thanks
| cargo test --features extensions |
There was a problem hiding this comment.
this part targets all tests, including the one in extensions module.
What we want is, just run the extensions module tests, but nothing else.
There was a problem hiding this comment.
Actually, I do not familiar with the Rust and Rust test command, just trying to work on the CI side but it seems complicated than I thought. So was not able to figure out the right cargo test command to run the extensions module tests only so far. If you have any hint or document related to this, please let me know. Thanks!
There was a problem hiding this comment.
docs: https://doc.rust-lang.org/cargo/commands/cargo-test.html#target-selection
something like this would work:
cargo test --features extensions --test tests extensions
There was a problem hiding this comment.
Thanks, I will check it to find the appropriate command for this case.
There was a problem hiding this comment.
I've found the command to run only extension test, it works on my forked repo:
cargo test --features=extensions extensions
https://github.com/tungbq/libsql/actions/runs/8028972291/job/21934748847#step:6:474
Hi @avinassh please help review again! Thanks
There was a problem hiding this comment.
@tungbq looks great! can you squash all the commits into a single one?
tungbq
force-pushed
the
fix-duplicated-test
branch
from
30dca7f to
272d1a4
Compare
Closes: #1077
ci: fix duplicated rust suites test
Only the
extensionstests