Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust suite tests are running twice #1077

Closed
avinassh opened this issue Feb 23, 2024 · 3 comments · Fixed by #1078
Closed

Rust suite tests are running twice #1077

avinassh opened this issue Feb 23, 2024 · 3 comments · Fixed by #1078
Labels
ci good first issue Good for newcomers

Comments

@avinassh
Copy link
Member

The PR #1027 added tests for extensions in the github workflow , but it runs the entire rust suite again (which are already run as part of rust workflow). It should run only the --extensions tests:

...
test extensions::test_sqlite_vss ... ok

https://github.com/tursodatabase/libsql/actions/runs/8015027296/job/21894572798
@avinassh avinassh added good first issue Good for newcomers ci labels Feb 23, 2024
@tungbq
Copy link
Contributor

tungbq commented Feb 23, 2024

Hi @avinassh I would like to work on this issue, could you help to guide me the full command to run extension test?

@avinassh
Copy link
Member Author

@tungbq sure!

cd libsql-sqlite3/test/rust_suite
cargo test --features extensions

@tungbq tungbq mentioned this issue Feb 23, 2024
Merged
@tungbq
Copy link
Contributor

tungbq commented Feb 23, 2024

Thank you @avinassh I've proposed PR #1078 to fix the issue. Please review and let me know if we need to have more update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix duplicated rust suites test tungbq/libsql
2 participants
@avinassh @tungbq