separate operator case so we do not need to resolve entity #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been tested and it indeed resolves the hotfix installed in ed_object_models and therefore #158 |
LarsJanssenTUe
previously approved these changes
Dec 14, 2021
MatthijsBurgh
requested changes
Dec 14, 2021
|
@MatthijsBurgh regarding the need for an attribute check for target_location.id: if this were needed this code would break on line 65 long before it reaches these changes |
MatthijsBurgh
approved these changes
Jan 3, 2022
|
Thanks @PetervDooren for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.