[AMD] Use Linear Layout convertions for AMDWmma #5255
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarman
reviewed
Nov 25, 2024
| @@ -389,7 +389,7 @@ struct ConvertLayoutOpUsingLinearLayoutsConversion | |||
| return true; | |||
| } | |||
| } | |||
| if (isa<AMDMfmaEncodingAttr>(parent)) { | |||
| if (isa<AMDMfmaEncodingAttr, AMDWmmaEncodingAttr>(parent)) { | |||
There was a problem hiding this comment.
Are you sure this will work?
This is a dot operand branch.
sjw36
reviewed
Nov 26, 2024
| @@ -376,7 +376,7 @@ struct ConvertLayoutOpUsingLinearLayoutsConversion | |||
| // completed before we can remove the layoutIsOK check: | |||
| // 1. Support for AMD's WMMA | |||
| std::function<bool(Attribute)> layoutIsOK = [&](Attribute layout) { | |||
| if (isa<NvidiaMmaEncodingAttr, AMDMfmaEncodingAttr>(layout)) { | |||
| if (isa<MmaEncodingTrait>(layout)) { | |||
There was a problem hiding this comment.
There is another Mfma case below (parent of DotOperand). Does it also need considered?
There was a problem hiding this comment.
It have not been implemented yet. I guess @binarman is assigned.
|
Also please add a testcase. |
Enable LL conwertions for WMMA as well as for MFMA layouts. See also: triton-lang#5210 Signed-off-by: Ilya Veselov <[email protected]>
sjw36
reviewed
Nov 26, 2024
| std::function<bool(Attribute)> layoutIsOK = [&](Attribute layout) { | ||
| if (auto dotOperand = dyn_cast<DotOperandEncodingAttr>(layout)) { | ||
| layout = dotOperand.getParent(); | ||
| if (isa<AMDWmmaEncodingAttr>(layout)) { |
There was a problem hiding this comment.
Please add a comment why this is special cased.
There was a problem hiding this comment.
Never mind, I see the adjusted comment above.
sjw36
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable LL conwertions for WMMA as well as for MFMA layouts.
See also: #5210