Skip to content

Commit

Permalink
[AMD] Use Linear Layout convertions for AMDWmma
Browse files Browse the repository at this point in the history
Enable LL conwertions for WMMA as well as for MFMA layouts.

See also: #5210

Signed-off-by: Ilya Veselov <[email protected]>
  • Loading branch information
joviliast committed Nov 25, 2024
1 parent 09fcc52 commit 2a3a84d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/Conversion/TritonGPUToLLVM/ConvertLayoutOpToLLVM.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ struct ConvertLayoutOpUsingLinearLayoutsConversion
// completed before we can remove the layoutIsOK check:
// 1. Support for AMD's WMMA
std::function<bool(Attribute)> layoutIsOK = [&](Attribute layout) {
if (isa<NvidiaMmaEncodingAttr, AMDMfmaEncodingAttr>(layout)) {
if (isa<MmaEncodingTrait>(layout)) {
return !useLegacyMMAConversion;
}
if (auto dotOperand = dyn_cast<DotOperandEncodingAttr>(layout)) {
Expand All @@ -389,7 +389,7 @@ struct ConvertLayoutOpUsingLinearLayoutsConversion
return true;
}
}
if (isa<AMDMfmaEncodingAttr>(parent)) {
if (isa<AMDMfmaEncodingAttr, AMDWmmaEncodingAttr>(parent)) {
return true;
}
return false;
Expand Down

0 comments on commit 2a3a84d

Please sign in to comment.