Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify negative SUPPORTS_CREATE_FUNCTION declarations #19777

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

findepi
Copy link
Member

@findepi findepi commented Nov 16, 2023

When BaseConnectorTest implementation declares that it does not have SUPPORTS_CREATE_FUNCTION behavior, verify this is true.

@cla-bot cla-bot bot added the cla-signed label Nov 16, 2023
Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

When `BaseConnectorTest` implementation declares that it does not have
`SUPPORTS_CREATE_FUNCTION` behavior, verify this is true.
@findepi findepi force-pushed the findepi/SUPPORTS_CREATE_FUNCTION branch from 6121ae2 to 6cd1458 Compare November 16, 2023 15:26
@findepi
Copy link
Member Author

findepi commented Nov 17, 2023

CI #11252 & sheets flake

@findepi findepi merged commit 4055fdf into trinodb:master Nov 17, 2023
81 of 83 checks passed
@findepi findepi deleted the findepi/SUPPORTS_CREATE_FUNCTION branch November 17, 2023 08:12
@github-actions github-actions bot added this to the 434 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants