Verify negative SUPPORTS_CREATE_FUNCTION declarations

When `BaseConnectorTest` implementation declares that it does not have `SUPPORTS_CREATE_FUNCTION` behavior, verify this is true.
trinodb · Nov 17, 2023 · 4055fdf · 4055fdf
1 parent 1f6792b
commit 4055fdf
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java b/testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
@@ -6553,7 +6553,14 @@ private void testMaterializedViewColumnName(String columnName, boolean delimited
     @Test
     public void testCreateFunction()
     {
-        skipTestUnless(hasBehavior(SUPPORTS_CREATE_FUNCTION));
+        if (!hasBehavior(SUPPORTS_CREATE_FUNCTION)) {
+            String catalog = getQueryRunner().getDefaultSession().getCatalog().orElseThrow();
+            String schema = getQueryRunner().getDefaultSession().getSchema().orElseThrow();
+            assertQueryFails(
+                    "CREATE FUNCTION " + catalog + "." + schema + ".test_create_function" + randomNameSuffix() + "(x integer) RETURNS bigint COMMENT 't42' RETURN x * 42",
+                    "This connector does not support creating functions");
+            return;
+        }
 
         String name = "test_" + randomNameSuffix();
         String name2 = "test_" + randomNameSuffix();