Update Iceberg from 1.3.1 to 1.4.1 #19434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
reviewed
Oct 22, 2023
findinpath
approved these changes
Oct 22, 2023
|
Please ping after Iceberg 1.4.1 is released officially. |
findepi
reviewed
Oct 23, 2023
| @@ -382,7 +382,7 @@ private static Metrics loadMetrics(TrinoInputFile file, HiveStorageFormat storag | |||
| InputFile inputFile = new ForwardingInputFile(file); | |||
| return switch (storageFormat) { | |||
| case ORC -> OrcMetrics.fromInputFile(inputFile, METRICS_CONFIG, nameMapping); | |||
| case PARQUET -> TrinoParquetUtil.fileMetrics(inputFile, METRICS_CONFIG, nameMapping); | |||
ebyhr
reviewed
Oct 23, 2023
| @@ -48,7 +48,6 @@ public static NessieIcebergClient createNessieIcebergClient(IcebergNessieCatalog | |||
| return new NessieIcebergClient( | |||
| HttpClientBuilder.builder() | |||
There was a problem hiding this comment.
HttpClientBuilder is deprecated now. Let's migrate to NessieClientBuilder in follow-up.
...iceberg/src/main/java/io/trino/plugin/iceberg/catalog/nessie/IcebergNessieCatalogModule.java
Show resolved
Hide resolved
...st/java/io/trino/plugin/iceberg/catalog/file/TestIcebergFileMetastoreCreateTableFailure.java
Show resolved
Hide resolved
ebyhr
added
the
no-release-notes
|
Please squash commits into one. |
|
/test-with-secrets sha=1b4c5f8687c2b0e23efa8374def53cf4184340b0 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/6620194009 |
.withEnableApiCompatibilityCheck(false) was introduced as a workaround and can be removed now. Details on the reasoning can be found at trinodb#17715 (comment) Co-authored-by: Fokko Driesprong <[email protected]>
ebyhr
approved these changes
Oct 24, 2023
findinpath
reviewed
Jan 17, 2024
| @@ -4704,7 +4704,7 @@ protected void verifyIcebergTableProperties(MaterializedResult actual) | |||
| assertThat(actual).isNotNull(); | |||
| MaterializedResult expected = resultBuilder(getSession()) | |||
| .row("write.format.default", format.name()) | |||
| .build(); | |||
| .row("write.parquet.compression-codec", "zstd").build(); | |||
There was a problem hiding this comment.
we should adress this as part of apache/iceberg#9490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.