Update Nessie to 0.71.0 #19510
Closed
Update Nessie to 0.71.0 #19510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this is being updated as part of #19434. |
|
@nastra can we split this change? it seems that Nessie update is independent of the Iceberg update |
|
@wendigo I don't think this should be separated, because the Nessie version should be matching the one used by Iceberg. That being said, we'd usually bump the Nessie version whenever bumping the Iceberg version |
|
@nastra How we can check/enforce it then? It seems that if I upgrade nessie version by mistake without upgrading Iceberg tests are passing |
ebyhr
reviewed
Oct 25, 2023
...iceberg/src/main/java/io/trino/plugin/iceberg/catalog/nessie/IcebergNessieCatalogModule.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't update to newest version as it relies on the newest jackson which will be updated soon in Trino.