-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation on Erlang 19 by updating rebar.config #25
Conversation
It just occurred to me that this doesn't work. Apparently exometer (or hut for that matter) needs an extra flag to use lager. I'm trying to find out how that has to be done. |
It turns out I only had to add lager to the app.src |
Hi @TBK145, |
I saw that there is some trouble with loggers, but with this pull request exometer still uses lager right? |
It uses I think you did some tests with the latest Please, correct me if I'm wrong. |
I'm not sure, but that might very well be possible. |
I currently have a workaround where I specify the newer lager dependency in my own project. Would it be a solution to add lager 3.2.1 as a dependency to this project and use the old exometer_core ref? |
Lets try |
I updated the PR, now it uses the same exometer_core commit as before, but lager 3.2.1 has been added as a dependency, so it compiles on Erlang 19. |
Good! Can you add some description about what you did it to overrided lager in rebar.config? |
And activate Erlang 19 in .travis.yml if it possible ;) |
The old exometer dependency had a lager dependency which did not compile on Erlang 19.
I added a comment to rebar.config and added Erlang 19 to .travis.yml. |
Thank you! |
The old exometer dependency had a lager dependency which did not compile on Erlang 19.
However, newer exometer versions do not have a lager dependency, so I had to add one manually, which fixed compilation on Erlang 19.