Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lager as a dependency #26

Closed
mootpointer opened this issue Aug 6, 2016 · 5 comments
Closed

Remove lager as a dependency #26

mootpointer opened this issue Aug 6, 2016 · 5 comments

Comments

@mootpointer
Copy link

Lager is no longer a dependency of exometer_core. It would be great to remove it from exometer_influxdb as well.

Is there anything internal which is requiring lager as the logger instead something like hut which the core project has moved to?

@surik
Copy link
Contributor

surik commented Aug 6, 2016

Hi @mootpointer.

Honestly this issue a little bit worrying me, see #21 and #25. I would like to get rid of lager and use the latest exometer_core with hut but I don't know how I can build exometer_core as a dependency with lager support. If you give me some hint I will be very grateful.

@mootpointer
Copy link
Author

I don't use lager personally I'm presently using Elixir, so Elixir.Logger picks things up from sasl, so I'm not really in a position to be able to make this work.

@surik
Copy link
Contributor

surik commented Aug 6, 2016

Yes, it is because hut uses sasl by default. But what if I want to use it with lager?

In my personal opinion I would just have sasl support in exometer_core and exometer_influxdb(without hut) because it is compatible with lager and Elixir logger. We may try to go this way.

@mootpointer
Copy link
Author

Forcing lager as a dependency in something like exometer_core or
exometer_influxdb seems like an anti-pattern.

On Sat, Aug 6, 2016 at 11:34 PM Yury Gargay [email protected]
wrote:

Yes, it is because hut uses sasl by default. But what if I want to use it
with lager?

In my personal opinion I would just have sasl support in exometer_core
and exometer_influxdb(without hut) because it is compatible with lager
and Elixir logger. We may try to go this way.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHv99OJdw9WqM023dSyf-r7KM4tpwuxks5qdI18gaJpZM4JeQ7F
.

@surik
Copy link
Contributor

surik commented Aug 8, 2016

See #27

@surik surik closed this as completed Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants