Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unrwaps/expects in qos client CLI #155

Open
emostov opened this issue Oct 31, 2022 · 1 comment
Open

Remove unrwaps/expects in qos client CLI #155

emostov opened this issue Oct 31, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@emostov
Copy link
Contributor

emostov commented Oct 31, 2022

The client CLI uses unwraps/expects everywhere. In order to make the lower level functions more re-usable across contexts we should have them returns errors instead of panicking. Additionally, it probably makes sense to exit with with a non-zero status code instead of panicking. I think not panicking should give us a better chance of clearing sensitive memory before exiting.

ref: #154 (review)

@emostov emostov added the good first issue Good for newcomers label Oct 31, 2022
@emostov
Copy link
Contributor Author

emostov commented Nov 1, 2022

Importantly, panics should also be removed from verify_attestation_doc_against_user_input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant