Remove RSA and use P256 everywhere #154

emostov · 2022-10-29T01:41:48Z

Use p256 everywhere
For keys: in memory we always store as raw bytes, on disk we always store as hex
Replace all the mock keys to use the new p256 stuff
Remove the sample-app, this is mostly unrelated but I didn't want to deal with maintaining it through this refactor and we have no use for it

Follow ups:

Remove unrwaps/expects in qos client CLI #155

src/qos_p256/src/lib.rs

src/qos_client/src/cli/services.rs

jack-kearney

LGTM

src/qos_client/src/cli/services.rs

mikelodder7

Not a fan or all these unwraps and expects. In general, its good practice to return Result or Option in the lower levels and only unwrap or panic at the app level.

mikelodder7 · 2022-10-31T18:27:11Z

src/qos_attest/Cargo.toml

Not seeing this used anywhere. Are you sure is still necessary?

Ya, its used for x509 cert stuff in the attestation module. Working on ripping it out right now in another branch

fwiw openssl will be completely removed once this PR & #156 are merged

mikelodder7 · 2022-10-31T18:28:06Z

src/qos_p256/src/lib.rs

 const P256_ENCRYPT_DERIVE_PATH: &[u8] = b"qos_p256_encrypt";
 const P256_SIGN_DERIVE_PATH: &[u8] = b"qos_p256_sign";

+/// Length of the master seed.
+pub const MASTER_SEED_LEN: usize = 64;


Do you really need 64 bytes? Seems overkill and adds nothing in terms of security. 32 bytes its more than enough.

64 is a bit arbitrary, but was thinking it could give us more flexibility in the future? Tbh though that was just a guess so I am fine with switching to 32

Agree with @mikelodder7. Security limit is already 128b because of the use of p256. Recommend 128b = 32B here.

Ok, this is now switched to 32.

src/qos_crypto/src/lib.rs

ace0

Left an optional comment. Otherwise, lgtm.

Co-authored-by: Michael Lodder <[email protected]>

…256-the-world

Co-authored-by: Michael Lodder <[email protected]>

…256-the-world

emostov added 17 commits October 28, 2022 21:34

qos_core compile but tests are broken

8cf94a8

Fix tests

314c1fe

lint

b5d9629

Remove sample app

48b4258

Get qos_client to compile

cc836f1

Genesis e2e working

0968b27

Lint

43009d3

Regen keys

06fe579

Try and regen genesis stuff for boot e2e

b435630

Try fixing boot e2e wip

4896121

Get boot e2e working

7822dcb

Lint

714e1c2

Revert genesis test

055f2f0

Lint

8fa1c84

Use sha2 crate in qos_crypto

db202fe

Remove RSA

a28e1e0

remove unused deps from qos crypto

cfce9e4

emostov changed the title ~~[WIP] Remove RSA and use P256 everywhere~~ Remove RSA and use P256 everywhere Oct 31, 2022

emostov added 2 commits October 31, 2022 14:12

Fix merge conflicts

361d414

lint

9ccb88d

emostov commented Oct 31, 2022

View reviewed changes

src/qos_p256/src/lib.rs Show resolved Hide resolved

mikelodder7 reviewed Oct 31, 2022

View reviewed changes

src/qos_client/src/cli/services.rs Outdated Show resolved Hide resolved

jack-kearney approved these changes Oct 31, 2022

View reviewed changes

mikelodder7 reviewed Oct 31, 2022

View reviewed changes

src/qos_client/src/cli/services.rs Outdated Show resolved Hide resolved

Base automatically changed from zeke-add-p256-authenticate to master October 31, 2022 18:23

mikelodder7 reviewed Oct 31, 2022

View reviewed changes

emostov mentioned this pull request Oct 31, 2022

Remove unrwaps/expects in qos client CLI #155

Open

emostov commented Oct 31, 2022

View reviewed changes

src/qos_crypto/src/lib.rs Outdated Show resolved Hide resolved

emostov and others added 2 commits October 31, 2022 14:33

Update src/qos_crypto/src/lib.rs

0619d4f

spelling

48cbc48

ace0 approved these changes Oct 31, 2022

View reviewed changes

emostov and others added 6 commits November 1, 2022 11:08

Regen genesis outputs

1f98fcb

other cleanup

3dc8462

Lint

1dbe3d6

Update src/qos_client/src/cli/services.rs

24dde46

Co-authored-by: Michael Lodder <[email protected]>

Merge branch 'zeke-p256-the-world' of github.com:tkhq/qos into zeke-p…

46449cd

…256-the-world

Update src/qos_client/src/cli/services.rs

14343c4

Co-authored-by: Michael Lodder <[email protected]>

emostov requested a review from mikelodder7 November 1, 2022 15:18

emostov added 3 commits November 1, 2022 13:06

Merge branch 'zeke-p256-the-world' of github.com:tkhq/qos into zeke-p…

ef355ef

…256-the-world

Try merge origin master

d620f43

Lint

99899eb

emostov merged commit a1c84e2 into master Nov 1, 2022

emostov deleted the zeke-p256-the-world branch November 1, 2022 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove RSA and use P256 everywhere #154

Remove RSA and use P256 everywhere #154

emostov commented Oct 29, 2022 •

edited

Loading

jack-kearney left a comment

mikelodder7 left a comment

mikelodder7 Oct 31, 2022

emostov Oct 31, 2022

emostov Nov 1, 2022

mikelodder7 Oct 31, 2022

emostov Oct 31, 2022

ace0 Oct 31, 2022

emostov Nov 1, 2022

ace0 left a comment

Remove RSA and use P256 everywhere #154

Remove RSA and use P256 everywhere #154

Conversation

emostov commented Oct 29, 2022 • edited Loading

jack-kearney left a comment

Choose a reason for hiding this comment

mikelodder7 left a comment

Choose a reason for hiding this comment

mikelodder7 Oct 31, 2022

Choose a reason for hiding this comment

emostov Oct 31, 2022

Choose a reason for hiding this comment

emostov Nov 1, 2022

Choose a reason for hiding this comment

mikelodder7 Oct 31, 2022

Choose a reason for hiding this comment

emostov Oct 31, 2022

Choose a reason for hiding this comment

ace0 Oct 31, 2022

Choose a reason for hiding this comment

emostov Nov 1, 2022

Choose a reason for hiding this comment

ace0 left a comment

Choose a reason for hiding this comment

emostov commented Oct 29, 2022 •

edited

Loading