Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qos_client: Bubble up errors instead of returning booleans and logging error messages #174

Open
emostov opened this issue Dec 5, 2022 · 1 comment
Open

qos_client: Bubble up errors instead of returning booleans and logging error messages #174

emostov opened this issue Dec 5, 2022 · 1 comment

Comments

@emostov
Copy link
Contributor

emostov commented Dec 5, 2022

Both run approve_manifest_programmatic_verifications and proxy_re_encrypt_share_programmatic_verifications run some checks, log any errors, and return a boolean indicating if any of the checks failed. To make things more clear, they should forgo logging the error and instead bubble up the error. This error can then be logged at the top level when the CLI exits.
@emostov
Copy link
Contributor Author

emostov commented Feb 13, 2023

relates to #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emostov