Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Voice Button component #287

Merged

Conversation

SDaniV
Copy link
Contributor

@SDaniV SDaniV commented Dec 18, 2024

Description

Add unit tests for Voice Button component

Closes #137

What change does this PR introduce?

Please select the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to docs/code comments)

What is the proposed approach?

An approach similar to the implementation of unit tests for Notification Button component is followed.

image

Checklist:

  • The commit message follows our adopted guidelines
  • [n/a] Testing has been done for the change(s) added (for bug fixes/features)
  • [n/a] Relevant comments/docs have been added/updated (for bug fixes/features)

@@ -1,10 +1,12 @@
// __mocks__/fileMock.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a reordering to have constants in alphabetical order plus added to constants: voiceIcon and voiceIconDisabled

@SDaniV SDaniV marked this pull request as ready for review December 18, 2024 12:34
Copy link
Owner

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 😊

@tjtanjin tjtanjin merged commit 1290669 into tjtanjin:main Dec 18, 2024
11 checks passed
@SDaniV SDaniV deleted the issue-137-unit-tests-for-VoiceButton-component branch December 18, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add unit test cases for VoiceButton component
2 participants