Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Add unit test cases for VoiceButton component #137

Closed
tjtanjin opened this issue Oct 6, 2024 · 8 comments · Fixed by #287
Closed

[Task] Add unit test cases for VoiceButton component #137

tjtanjin opened this issue Oct 6, 2024 · 8 comments · Fixed by #287
Assignees
Labels

Comments

@tjtanjin
Copy link
Owner

tjtanjin commented Oct 6, 2024

Task Description:
Currently, we run unit tests using jest which can be found here.

However, the test cases are not yet comprehensive enough and work can be done to cover more grounds. Specifically for this issue, we hope to add test cases for the VoiceButton component.

Deliverable(s):
New unit test cases that cover the testing of the VoiceButton component.

Additional Context:

  • Button components can be found here
  • An example for AudioButton can be found here which may serve as a good source for reference
@jerry-604
Copy link

I'll like to work on this...

@tjtanjin
Copy link
Owner Author

tjtanjin commented Oct 8, 2024

I'll like to work on this...

Go for it!

@tjtanjin
Copy link
Owner Author

Hey @jerry-604, are you facing any problems with this issue? If so, feel free to reach out for clarifications!

@tjtanjin
Copy link
Owner Author

Hey @jerry-604, with hacktoberfest coming to a close very soon, I'll be leaving this issue un-assigned for any final PRs. This is to minimize leftover issues and provide an opportunity for those looking to get that last few PRs in. Feel free to continue with a PR if you're still working on this issue and I seek your kind understanding, thank you! 😊

@Elisassa
Copy link

Hi! If there is no one working on this I would like to have a try!

@tjtanjin
Copy link
Owner Author

Hi! If there is no one working on this I would like to have a try!

Go for it!

@Elisassa
Copy link

Hi I have made PR pls check if it's ok

@SDaniV
Copy link
Contributor

SDaniV commented Dec 18, 2024

Hey @tjtanjin! I found that the issue has been hanging unchanged for more than a month now so I decided to give it a try and created alternative PR to resolve it. Please, review when you have time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants