Support to integrate with the PD HTTP client #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
integrate_pd_http_client
branch
from
06067e5
to
2f38378
Compare
3 tasks
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
lhy1024
approved these changes
Nov 7, 2023
|
Can you pass the integration test in your local host? |
HuSharp
reviewed
Nov 7, 2023
| @@ -195,9 +198,9 @@ func WithPool(gp Pool) Option { | |||
| } | |||
|
|
|||
| // WithPDHTTPClient set the PD HTTP client with the given address and TLS config. | |||
| func WithPDHTTPClient(tlsConf *tls.Config, pdaddrs []string) Option { | |||
| func WithPDHTTPClient(pdAddrs []string, tlsConf *tls.Config) Option { | |||
There was a problem hiding this comment.
Does it make a compatibility error to TiDB?
There was a problem hiding this comment.
When upgrading client-go, we will naturally perceive this modification before and after compilation. I don't think it will cause compatibility problems.
JmPotato
force-pushed
the
integrate_pd_http_client
branch
from
ad76bad
to
5b11c78
Compare
HuSharp
reviewed
Nov 7, 2023
tikv/kv.go
Outdated
| @@ -640,8 +651,10 @@ func (s *KVStore) updateSafeTS(ctx context.Context) { | |||
| return | |||
| } | |||
| safeTS = resp.Resp.(*kvrpcpb.StoreSafeTSResponse).GetSafeTs() | |||
| logutil.BgLogger().Info("get min resolved ts from tikv", zap.Uint64("store-id", storeID), zap.Uint64("safe-ts", safeTS)) | |||
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
integrate_pd_http_client
branch
from
5b11c78
to
90bf021
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref tikv/pd#7300, tikv/pd#7304