Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: integrate PD HTTP client to the store helper #48276

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Nov 3, 2023

What problem does this PR solve?

Issue Number: ref #35319, tikv/pd#7300. Should merge after tikv/client-go#1049 and tikv/pd#7304.

Problem Summary:

What is changed and how it works?

  • Integrate the unified PD HTTP client to store/helper package.
  • Replace the PD types with the HTTP SDK.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Nov 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 3, 2023
Copy link

tiprow bot commented Nov 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added component/dumpling This is related to Dumpling of TiDB. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 3, 2023
@JmPotato JmPotato force-pushed the integrate_pd_http_client branch 3 times, most recently from e06ae66 to 350fe60 Compare November 7, 2023 07:04
@JmPotato JmPotato marked this pull request as ready for review November 7, 2023 09:09
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #48276 (57d8560) into master (911334b) will increase coverage by 1.4209%.
Report is 3 commits behind head on master.
The diff coverage is 68.8524%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48276        +/-   ##
================================================
+ Coverage   71.4298%   72.8508%   +1.4209%     
================================================
  Files          1404       1428        +24     
  Lines        407212     413799      +6587     
================================================
+ Hits         290871     301456     +10585     
+ Misses        96393      93416      -2977     
+ Partials      19948      18927      -1021     
Flag Coverage Δ
integration 43.3064% <5.9829%> (?)
unit 71.4580% <68.8524%> (+0.0281%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <100.0000%> (ø)
parser ∅ <ø> (∅)
br 48.8259% <0.0000%> (-4.2325%) ⬇️

@JmPotato JmPotato force-pushed the integrate_pd_http_client branch 3 times, most recently from 7e19165 to c9b3893 Compare November 13, 2023 06:58
@JmPotato JmPotato changed the title *: integrate with the PD HTTP client *: integrate PD HTTP client to the store helper Nov 13, 2023
@JmPotato JmPotato force-pushed the integrate_pd_http_client branch 4 times, most recently from c24e4f0 to fdbb36b Compare November 14, 2023 09:53
@JmPotato JmPotato force-pushed the integrate_pd_http_client branch from fdbb36b to 4d7350d Compare November 14, 2023 09:57
Signed-off-by: JmPotato <[email protected]>
@JmPotato JmPotato force-pushed the integrate_pd_http_client branch 3 times, most recently from c8f0ad3 to 7801129 Compare November 14, 2023 16:45
Signed-off-by: JmPotato <[email protected]>
@JmPotato JmPotato force-pushed the integrate_pd_http_client branch from 7801129 to 57d8560 Compare November 14, 2023 17:04
@JmPotato
Copy link
Member Author

Please help take a look, thx.

/cc @YuJuncen @zimulala @tangenta @hawkingrei

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 15, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 15, 2023
Copy link

ti-chi-bot bot commented Nov 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-15 02:43:17.604370491 +0000 UTC m=+4216995.191480654: ☑️ agreed by hawkingrei.
  • 2023-11-15 03:14:35.570549359 +0000 UTC m=+4218873.157659489: ☑️ agreed by tangenta.

Copy link

ti-chi-bot bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lichunzhu, tangenta, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0f35b6f into pingcap:master Nov 15, 2023
27 of 31 checks passed
@JmPotato JmPotato deleted the integrate_pd_http_client branch November 15, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants