This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Fix/account service #249
Merged
Fix/account service #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need to support both 1/4 and 1/5 increments
but none of this is good/ready to go.
note: because the callbacks are async, it's not guaranteed that all of the accounts have been processed by the app layer before onComplete. This means, we should NOT return the account list from the load function, since the result can be incorrect.
adds scan method
|
merging even tho codeql fails because capture lib cannot be found — it's not ready for publishing yet, so it must be referenced locally from source. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Addressed
relates to #217
Additional Information
Adds the capture service, with the account methods tested, integrated, and mostly functional. Logout is currently broken at the capture layer.