Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Fix/imap and scanning warnings sheets #232

Merged
merged 11 commits into from
Oct 16, 2023
Merged

Conversation

MiroBenicio
Copy link
Contributor

Issues Addressed

Closes #229
Closes #230

Additional Information

sheets based on the actual wireframe and design

@MiroBenicio MiroBenicio added the fix Iterations on existing features or infrastructure. label Sep 27, 2023
@MiroBenicio MiroBenicio changed the title Fix/handle imap disabled warning Fix/imap and scanning warnings sheets Sep 27, 2023
@mike-audi
Copy link
Contributor

This PR simply need a UI/UX review before merge.

@MiroBenicio can you post screenshots for @timoguin to review the language. I will take care of the formatting/stylizing

@MiroBenicio
Copy link
Contributor Author

@timoguin

image
image

@mike-audi
Copy link
Contributor

okay. these screens are now pretty and formatted.

@MiroBenicio & @timoguin — please decide on the language you want to use, update copy, and then merge. The code itself is good to go, the copy is not.

Copy link
Contributor

@mike-audi mike-audi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy editing required by @timoguin

@timoguin
Copy link
Contributor

Just tested the Vue2 build and had issues:

I also experienced something similar to the issue reported here: #311

If you connect an email that has IMAP disabled, it shows no errors. However, if you close and reopen the app, that email account no longer shows in the list of accounts. I was able to reconnect the same account again.

@mike-audi
Copy link
Contributor

Just tested the Vue2 build and had issues:

I also experienced something similar to the issue reported here: #311

If you connect an email that has IMAP disabled, it shows no errors. However, if you close and reopen the app, that email account no longer shows in the list of accounts. I was able to reconnect the same account again.

This story is just for the screens themselves, not the business logic. Those require additional and separate stories with clear logic & requirements.

Copy link
Contributor

@timoguin timoguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the copy is okay in this.

@timoguin timoguin requested a review from mike-audi October 16, 2023 16:13
# Conflicts:
#	example/vue2/android/gradlew.bat
#	example/vue3/android/gradlew.bat
@mike-audi mike-audi merged commit 89e323d into main Oct 16, 2023
4 checks passed
@mike-audi mike-audi deleted the fix/handle-imap-disabled-warning branch October 16, 2023 20:31
@mike-audi
Copy link
Contributor

@timoguin please note this is being merged in but the business logic is not implemented. Open stories with descriptions of how exactly you want the business logic to work and we will make these screens "show"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Create "long scan" dialog and push notification [UI] Handle IMAP disabled warning
3 participants