-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This PR simply need a UI/UX review before merge. @MiroBenicio can you post screenshots for @timoguin to review the language. I will take care of the formatting/stylizing |
- includes formatting fix for close icon
okay. these screens are now pretty and formatted. @MiroBenicio & @timoguin — please decide on the language you want to use, update copy, and then merge. The code itself is good to go, the copy is not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy editing required by @timoguin
Just tested the Vue2 build and had issues:
I also experienced something similar to the issue reported here: #311 If you connect an email that has IMAP disabled, it shows no errors. However, if you close and reopen the app, that email account no longer shows in the list of accounts. I was able to reconnect the same account again. |
This story is just for the screens themselves, not the business logic. Those require additional and separate stories with clear logic & requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the copy is okay in this.
# Conflicts: # example/vue2/android/gradlew.bat # example/vue3/android/gradlew.bat
@timoguin please note this is being merged in but the business logic is not implemented. Open stories with descriptions of how exactly you want the business logic to work and we will make these screens "show" |
Issues Addressed
Closes #229
Closes #230
Additional Information
sheets based on the actual wireframe and design