Fix loading in contracts table

[0oM4R]

Description

the issue was that we were set loading for other table to false before it already done and it shows no data for while before finish listing its contract

Changes

add new function that handle updating loading value of tables

Related Issues

• UI Enhancement : loading in contracts page giving no contracts before loading #2752

please note that this pr is fixing loading issue only, there are other issues got opened related to contracts table #2800 and #2798

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Screencast.from.28.2024.EEST.05.43.03.webm

Checklist

• Tests included
• Build pass
• Documentation
• Code format and docstrings
• Screenshots/Video attached (needed for UI changes)

[AlaaElattar]

I liked ur function a lot. Great Job

[xmonader]

you could do a switch on contractType if your actions are going to be different, and also you don't need elseifs in your code given you do a return already in updateAllTables so you can safely start a new if or a switch

if updateAllTables {
            .... 
            return 
 }
switch contractType {
         case contractType.Name: 
                     isLoadingName.value = loading
                     break
         case 2: ...
         case 3:..
 }

[Mahmoud-Emad]

Good job ya Omar :)

[Mahmoud-Emad]

IMO. To improve code readability and maintainability, consider introducing an object instead of using named parameters.

// Define a type for the options
type ContractsLoadingOptions = {
  updateAllTables: boolean;
  loading: boolean;
  contractType?: boolean;
}

function updateContractsLoading(options: ContractsLoadingOptions) {}

// Example call
updateContractsLoading({
  updateAllTables: true,
  loading: false,
});