Fix issue with completing idents in the language server #2917
Conversation
Tatskaari
force-pushed
the
fix-ident-completion
branch
from
7565012 to
448e73b
Compare
| @@ -111,7 +111,7 @@ func (h *Handler) completeIdent(doc *doc, s string, line, col int) (*lsp.Complet | |||
| list := &lsp.CompletionList{} | |||
| for name, f := range h.builtins { | |||
| if strings.HasPrefix(name, s) { | |||
| item := completionItem(name, s, line, col) | |||
| item := completionItem(name, "", line, col) | |||
There was a problem hiding this comment.
If we're completing "check_" to "check_config", name would be "check_config", and s would have been "check_". We would then produce a replacement from "check_" to "config", rather than to the full "check_config" because we strip this prefix. I think this prefix is for when we complete labels within a package. We would have a list of completions with just the target name, and the prefix would be the //foo: bit.
The prefix would be //foo: but the completion list would contain just the label name, i.e. "bar" (as opposed to "//foo:bar". We then produce an edit for the column after the : to insert just the name rather than replacing the full label. This is not the case for idents though. I have tested completing member functions too, and they work just fine.
Tatskaari
changed the title
Not totally confident this is 100% correct but in my testing, this resolves the issue.
Fixes: #2906