Fix issue with completing idents in the language server (#2917)

* Don't trim prefix from ident completions * Fix test
thought-machine · Nov 1, 2023 · fe0b151 · fe0b151
1 parent 22f0242
commit fe0b151
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tools/build_langserver/lsp/completion.go b/tools/build_langserver/lsp/completion.go
@@ -111,7 +111,7 @@ func (h *Handler) completeIdent(doc *doc, s string, line, col int) (*lsp.Complet
 	list := &lsp.CompletionList{}
 	for name, f := range h.builtins {
 		if strings.HasPrefix(name, s) {
-			item := completionItem(name, s, line, col)
+			item := completionItem(name, "", line, col)
 			item.Documentation = f.Stmt.FuncDef.Docstring
 			item.Kind = lsp.CIKFunction
 			list.Items = append(list.Items, item)

diff --git a/tools/build_langserver/lsp/lsp_test.go b/tools/build_langserver/lsp/lsp_test.go
@@ -457,7 +457,7 @@ func TestCompletionFunction(t *testing.T) {
 			Label:            "plugin_repo",
 			Kind:             lsp.CIKFunction,
 			InsertTextFormat: lsp.ITFPlainText,
-			TextEdit:         textEdit("in_repo", 0, 4),
+			TextEdit:         textEdit("plugin_repo", 0, 4),
 			Documentation:    h.builtins["plugin_repo"].Stmt.FuncDef.Docstring,
 		}},
 	}, completions)
@@ -491,7 +491,7 @@ func TestCompletionPartialFunction(t *testing.T) {
 			Label:            "plugin_repo",
 			Kind:             lsp.CIKFunction,
 			InsertTextFormat: lsp.ITFPlainText,
-			TextEdit:         textEdit("po", 0, 9),
+			TextEdit:         textEdit("plugin_repo", 0, 9),
 			Documentation:    h.builtins["plugin_repo"].Stmt.FuncDef.Docstring,
 		}},
 	}, completions)