fix plz run - and plz exec - when stdin is empty (#2936)

* add test for plz run and exec from stdin --------- Co-authored-by: rgodden <[email protected]>
thought-machine · Nov 1, 2023 · ba47b76 · ba47b76
1 parent fe0b151
commit ba47b76
Show file tree

Hide file tree

Showing 5 changed files with 48 additions and 4 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,8 +1,16 @@
 Version 17.4.0
 --------------
-    * added --keep_going which continues exhasting tasks from the queue even
-      on failures. This can be useful if you want to collect all possible errors
-      in a single please build.
+    * keep going flag (#2932)
+    * Fix query somepath when it encounters a cycle (#2893)
+    * Fix text_file strip (#2895)
+      it now doesn't strip tabs and \ characters.
+    * plz run parallel/sequential accepts inline args (#2916)
+    * use character semantics for length and index operations on strings (#2921)
+    * Add chr built-in function (#2922)
+    * Add ord built-in function (#2924)
+    * Add all commit date formats to supported git_show() format verbs (#2930)
+    * Fix reduce builtin (#2925)
+    * Fix issue with completing idents in the language server (#2917)
 
 Version 17.3.1
 --------------

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-17.4.0-beta.1
+17.4.0-beta.2
diff --git a/src/please.go b/src/please.go
@@ -555,6 +555,9 @@ var buildFunctions = map[string]func() int{
 	},
 	"exec.sequential": func() int {
 		annotated, unannotated, args := opts.Exec.Sequential.Args.Targets.Separate()
+		if len(unannotated) == 0 {
+			return 0
+		}
 		success, state := runBuild(unannotated, true, false, false)
 		if !success {
 			return toExitCode(success, state)
@@ -566,6 +569,9 @@ var buildFunctions = map[string]func() int{
 	},
 	"exec.parallel": func() int {
 		annotated, unannotated, args := opts.Exec.Parallel.Args.Targets.Separate()
+		if len(unannotated) == 0 {
+			return 0
+		}
 		success, state := runBuild(unannotated, true, false, false)
 		if !success {
 			return toExitCode(success, state)
@@ -597,6 +603,9 @@ var buildFunctions = map[string]func() int{
 	},
 	"run.parallel": func() int {
 		annotated, unannotated, args := opts.Run.Parallel.PositionalArgs.Targets.Separate()
+		if len(unannotated) == 0 {
+			return 0
+		}
 		if success, state := runBuild(unannotated, true, false, false); success {
 			var dir string
 			if opts.Run.WD != "" {
@@ -610,6 +619,9 @@ var buildFunctions = map[string]func() int{
 	},
 	"run.sequential": func() int {
 		annotated, unannotated, args := opts.Run.Sequential.PositionalArgs.Targets.Separate()
+		if len(unannotated) == 0 {
+			return 0
+		}
 		if success, state := runBuild(unannotated, true, false, false); success {
 			var dir string
 			if opts.Run.WD != "" {

diff --git a/test/exec/BUILD b/test/exec/BUILD
@@ -32,3 +32,15 @@ please_repo_e2e_test(
     plz_command = "plz exec parallel //:failure",
     repo = "test_repo",
 )
+
+please_repo_e2e_test(
+    name = "exec_stdin_parallel_test",
+    plz_command = "echo '' | plz exec parallel -",
+    repo = "test_repo",
+)
+
+please_repo_e2e_test(
+    name = "exec_stdin_sequential_test",
+    plz_command = "echo '' | plz exec sequential -",
+    repo = "test_repo",
+)
diff --git a/test/plz_run/BUILD b/test/plz_run/BUILD
@@ -38,6 +38,18 @@ please_repo_e2e_test(
     repo = "test_repo",
 )
 
+please_repo_e2e_test(
+    name = "std_in_empty_parallel_test",
+    plz_command = "echo '' | plz run parallel -",
+    repo = "test_repo",
+)
+
+please_repo_e2e_test(
+    name = "std_in_empty_sequential_test",
+    plz_command = "echo '' | plz run sequential -",
+    repo = "test_repo",
+)
+
 please_repo_e2e_test(
     name = "std_in_sequential_test",
     expected_output = {