Topology2: rename sof-lnl-rt712-rt1320x1 #9635
Conversation
The rt1320 could use the same SoundWire link as rt712. In that case there is still one rt1320, but the NUM_SDW_AMP_LINKS should be 1. Name the tplg with the exact link number to avoid confusing. Signed-off-by: Bard Liao <[email protected]>
| @@ -18,7 +18,7 @@ SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack" | |||
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\ | |||
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack" | |||
|
|
|||
| "cavs-sdw\;sof-lnl-rt712-rt1320x1\;PLATFORM=lnl,SDW_DMIC=1,NUM_SDW_AMP_LINKS=2,\ | |||
| "cavs-sdw\;sof-lnl-rt712-l2-rt1320-l1\;PLATFORM=lnl,SDW_DMIC=1,NUM_SDW_AMP_LINKS=2,\ | |||
There was a problem hiding this comment.
I guess there's a matching kernel patch to updat ethe name and we haven't shipped this in sof-bin, so no problem to rename, right?
There was a problem hiding this comment.
Yes, the corresponding kernel PR is thesofproject/linux#5223. And the tplg PR was just merged 3 days ago. #9632
There was a problem hiding this comment.
@bardliao for CI, do you need this PR or kernel PR merged 1st ?
There was a problem hiding this comment.
We don't have any CI device with this configuration. So, it will not impact CI. However, I prefer merge kernel PR first to align the tplg name.
There was a problem hiding this comment.
We could merge this PR as thesofproject/linux#5223 is merged.
There was a problem hiding this comment.
Ack, was just waiting for the kernel part to be merged (which it is now).
The rt1320 could use the same SoundWire link as rt712. In that case there is still one rt1320, but the NUM_SDW_AMP_LINKS should be 1. Name the tplg with the exact link number to avoid confusing.