ASoC: Intel: soc-acpi-intel-lnl-match: add rt712_vb + rt1320 support #5223
Conversation
bardliao
requested review from
lgirdwood,
plbossart,
kv2019i and
dbaluta
as code owners
| * its headset, amp and dmic functions. | ||
| */ | ||
| static const struct snd_soc_acpi_endpoint rt722_endpoints[] = { | ||
| static const struct snd_soc_acpi_endpoint rt_sdca_mf_endpoints[] = { |
There was a problem hiding this comment.
isn't this a bit too broad assumption? By the name it is covering all RT SDCA codecs.
There was a problem hiding this comment.
isn't this a bit too broad assumption? By the name it is covering all RT SDCA codecs.
I think all Realtek SDCA multi function codecs can apply this endpoint array unless there is another endpoint array specific to a codec. @shumingfan Can you confirm it?
There was a problem hiding this comment.
For now, only jack/mic/amp are in the multi-function codec. But I am not sure if there is any difference with the future multi-function codec.
There was a problem hiding this comment.
Changed to jack_amp_dmic_endpoints
bardliao
force-pushed
the
for-rt712-rt1320
branch
from
655394d to
df3568d
Compare
|
Sorry, I would like to change the tplg name to |
bardliao
force-pushed
the
for-rt712-rt1320
branch
from
df3568d to
48108db
Compare
@bardliao, I'm not following this comment. |
In short, I changed the tplg name from sof-lnl-rt712-rt1320x1 to sof-lnl-rt712-l2-rt1320-l1 thesofproject/sof#9635. |
|
sof-lnl-rt712-l2-rt1320-l1.tplg - NUM_SDW_AMP_LINKS=2 sof-lnl-rt712-l1-rt1320-l2.tplg is also a valid setup? |
Exactly |
| .links = lnl_sdw_rt712_vb_l2_rt1320_l1, | ||
| .drv_name = "sof_sdw", | ||
| .sof_tplg_filename = "sof-lnl-rt712-l2-rt1320-l1.tplg" |
There was a problem hiding this comment.
nitpick: need to be careful as we are mixing _ with - for strings in the same structure.
There was a problem hiding this comment.
nitpick: need to be careful as we are mixing
_with-for strings in the same structure.
Agree, the convention is to use -
| @@ -93,6 +93,30 @@ static const struct snd_soc_acpi_endpoint jack_amp_dmic_endpoints[] = { | |||
| }, | |||
| }; | |||
|
|
|||
| static const struct snd_soc_acpi_endpoint jack_amp_g1_dmic_endpoints_endpoints[] = { | |||
There was a problem hiding this comment.
I cannot see where you;re reusing jack_amp_dmic_endpoints that you renamed in the first commit @bardliao
There was a problem hiding this comment.
I didn't reuse that one because it will only work for the configuration without additional amps.
There was a problem hiding this comment.
then do you want to drop it for now. It doesnt make sense in this PR and the commit specifically says you are going to reuse in the following commit and then you ont
Realtek Gen6 AIOC supports rt712_vb on SoundWire link 2 and rt1320 on SoundWire link 1. Signed-off-by: Bard Liao <[email protected]>
bardliao
force-pushed
the
for-rt712-rt1320
branch
from
48108db to
ba98473
Compare
rt712_vb on SDW link 2 and 1 rt1320 on SDW link 1 which is one of the audio configurations of Realtek Gen6 AIOC.